feat: msix auto-updater by bitdisaster · Pull Request #49230 · electron/electron

bitdisaster · 2025-12-18T01:44:11Z

Description of Change

This PR implements MSIX auto-updating according to electron/rfcs#21 . The new upater module supports auto-updating via:

Mac.Squirrel JSON server format

{
  "url": "https://mycompany.example.com/myapp/package.msix",
  "name": "My Release Name",
  "notes": "Theses are some release notes innit",
  "pub_date": "2013-09-18T12:29:53+01:00"
}

Mac.Squirrel static update file format

{
  "currentRelease": "2.0.0",
  "releases": [
    {
      "version": "1.0.0",
      "updateTo": {
        "version": "1.0.0",
        "pub_date": "2013-09-18T12:29:53+01:00",
        "notes": "Theses are some release notes innit",
        "name": "1.2.1",
        "url": "https://mycompany.example.com/myapp/package_1.msix""
      }
    },
    {
      "version": 2.0.0",
      "updateTo": {
        "version": "2.0.0",
        "pub_date": "2014-09-18T12:29:53+01:00",
        "notes": "Theses are some more release notes innit",
        "name": "1.2.3",
        "url": "https://mycompany.example.com/myapp/package_2.msix"
      }
    }
  ]
}

direct MSIX url link
https://mycompany.example.com/myapp/package.msix

Additonally, MSIX supports downgrading by setting allowAnyVersion. False by default.

 autoUpdater.setFeedURL({ url: 'https://mycompany.example.com/myapp/package.msix', allowAnyVersion: true }

Checklist

PR description included and stakeholders cc'd
npm test passes
tests are changed or added
relevant API documentation, tutorials, and examples are updated and follow the documentation style guide
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Added support for MSIX auto-updating

docs/api/auto-updater.md

lib/browser/api/auto-updater.ts

samuelmaddock · 2026-01-06T20:50:33Z

shell/browser/api/electron_api_msix_updater.cc

+// Helper function for debug logging
+void DebugLog(std::string_view log_msg) {
+  if (electron::debug_msix_updater)
+    LOG(INFO) << std::string(log_msg);
+}


I could see this info being useful enough that I could be in favor of including it without the flag. As in, only requiring ELECTRON_ENABLE_LOGGING.

Yeah I'm not sure about this either. I followed the model we have in the windows notification code.

spec/lib/msix-helpers.ts

VerteDinde

From a code perspective, looks good, but we'll need two API approvals before we can merge 🙇‍♀️

docs/api/structures/package-info.md

docs/api/auto-updater.md

erickzhao

API LGTM

MarshallOfSound

Approving code, let's make the package info api private then will API stamp

MarshallOfSound

API LGTM

release-clerk · 2026-01-29T21:38:29Z

Release Notes Persisted

Added support for MSIX auto-updating

MarshallOfSound · 2026-01-30T04:18:25Z

/trop run backport

trop · 2026-01-30T04:18:28Z

The backport process for this PR has been manually initiated - here we go! :D

trop · 2026-01-30T04:20:47Z

I have automatically backported this PR to "39-x-y", please check out #49585

trop · 2026-01-30T04:20:53Z

I have automatically backported this PR to "41-x-y", please check out #49586

trop · 2026-01-30T04:20:56Z

I have automatically backported this PR to "40-x-y", please check out #49587

electron-cation bot added the new-pr 🌱 PR opened recently label Dec 18, 2025

bitdisaster marked this pull request as draft December 18, 2025 01:46

bitdisaster marked this pull request as ready for review December 18, 2025 21:35

electron-cation bot removed the new-pr 🌱 PR opened recently label Dec 25, 2025

samuelmaddock reviewed Jan 6, 2026

View reviewed changes

bitdisaster requested a review from samuelmaddock January 7, 2026 00:18

bitdisaster force-pushed the msix-auto-updater branch from dbe31c5 to aa15f79 Compare January 16, 2026 19:36

erickzhao added no-backport semver/minor backwards-compatible functionality labels Jan 20, 2026

electron-cation bot added the api-review/requested 🗳 label Jan 22, 2026

VerteDinde approved these changes Jan 23, 2026

View reviewed changes

erickzhao reviewed Jan 23, 2026

View reviewed changes

docs/api/structures/package-info.md Outdated Show resolved Hide resolved

docs/api/structures/package-info.md Outdated Show resolved Hide resolved

docs/api/auto-updater.md Outdated Show resolved Hide resolved

erickzhao approved these changes Jan 23, 2026

View reviewed changes

MarshallOfSound approved these changes Jan 26, 2026

View reviewed changes

electron-cation bot added api-review/approved ✅ and removed api-review/requested 🗳 labels Jan 26, 2026

bitdisaster added 13 commits January 27, 2026 12:27

feat: native auto updater for MSIX on Windows

858e0d9

doc: added MSIX debug documentation

ea3a706

fix: allow downgrade with json release file and emit update-available

5f77129

test: msix auot-update tests

c251d11

doc: API documentation

2b1379a

test: add package version validation

cc6077f

fix: docs typo

89f5c7a

fix: don't allow auto-updating when using appinstaller manifest

467309c

fix: getPackageInfo interface implementation

a50ad40

fix: review feedback, add comment

cb9775a

fix: missed filename commit

1907e44

fix: install test cert on demand

2111fb6

fix: time stamp mismatch in tests

e60a9b8

bitdisaster force-pushed the msix-auto-updater branch from 167e3da to bebdf5e Compare January 27, 2026 20:31

fix: type error bcause of removed API

8d1cf0a

jkleinsc approved these changes Jan 29, 2026

View reviewed changes

jkleinsc merged commit d74fcfc into electron:main Jan 29, 2026
459 of 469 checks passed

MarshallOfSound added target/39-x-y PR should also be added to the "39-x-y" branch. target/40-x-y PR should also be added to the "40-x-y" branch. target/41-x-y PR should also be added to the "41-x-y" branch. labels Jan 30, 2026

This was referenced Jan 30, 2026

feat: msix auto-updater #49585

Merged

feat: msix auto-updater #49586

Merged

feat: msix auto-updater #49587

Merged

trop bot added the in-flight/39-x-y label Jan 30, 2026

trop bot removed the target/39-x-y PR should also be added to the "39-x-y" branch. label Jan 30, 2026

trop bot added in-flight/41-x-y in-flight/40-x-y and removed target/41-x-y PR should also be added to the "41-x-y" branch. target/40-x-y PR should also be added to the "40-x-y" branch. labels Jan 30, 2026

VerteDinde mentioned this pull request Feb 1, 2026

fix: fix Windows MSIX release build errors #49613

Merged

5 tasks

trop bot added merged/39-x-y PR was merged to the "39-x-y" branch. merged/41-x-y PR was merged to the "41-x-y" branch. merged/40-x-y PR was merged to the "40-x-y" branch. and removed in-flight/39-x-y in-flight/41-x-y in-flight/40-x-y labels Feb 2, 2026

VerteDinde mentioned this pull request Feb 3, 2026

refactor: use ComPtr pattern for MSIX to avoid exception handling #49645

Merged

6 tasks

Conversation

bitdisaster commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Checklist

Release Notes

Uh oh!

Uh oh!

Uh oh!

samuelmaddock Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

bitdisaster Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

VerteDinde left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erickzhao left a comment

Choose a reason for hiding this comment

Uh oh!

MarshallOfSound left a comment

Choose a reason for hiding this comment

Uh oh!

MarshallOfSound left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

release-clerk bot commented Jan 29, 2026

Uh oh!

MarshallOfSound commented Jan 30, 2026

Uh oh!

trop bot commented Jan 30, 2026

Uh oh!

trop bot commented Jan 30, 2026

Uh oh!

trop bot commented Jan 30, 2026

Uh oh!

trop bot commented Jan 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

bitdisaster commented Dec 18, 2025 •

edited

Loading