Skip to content

docs: remove postinstall lifecycle warning#50359

Merged
jkleinsc merged 2 commits intoelectron:mainfrom
A-Star100:main
Mar 20, 2026
Merged

docs: remove postinstall lifecycle warning#50359
jkleinsc merged 2 commits intoelectron:mainfrom
A-Star100:main

Conversation

@A-Star100
Copy link
Copy Markdown
Contributor

@A-Star100 A-Star100 commented Mar 19, 2026 •
edited
Loading

Description of Change

remove postinstall lifecycle warnings because they are redundant as of electron v42

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes new-pr 🌱 PR opened recently labels Mar 19, 2026
@A-Star100 A-Star100 deleted the branch electron:main March 19, 2026 01:29
@A-Star100 A-Star100 closed this Mar 19, 2026
@A-Star100 A-Star100 deleted the main branch March 19, 2026 01:29
@A-Star100 A-Star100 restored the main branch March 19, 2026 01:30
@A-Star100 A-Star100 reopened this Mar 19, 2026
@A-Star100
Copy link
Copy Markdown
Contributor Author

A-Star100 commented Mar 19, 2026

whoops, did an rename and it deleted the branch...

jkleinsc
jkleinsc requested changes Mar 19, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole warning should be removed.

@A-Star100 A-Star100 changed the title docs: change postinstall lifecycle warning to only apply for electron v41 and below docs: remove postinstall lifecycle warning Mar 19, 2026
@A-Star100 A-Star100 requested a review from jkleinsc March 19, 2026 18:33
@jkleinsc jkleinsc added the target/42-x-y PR should also be added to the "42-x-y" branch. label Mar 19, 2026
@A-Star100
Copy link
Copy Markdown
Contributor Author

A-Star100 commented Mar 19, 2026 •
edited
Loading

@jkleinsc in the rfcs PR for the postinstall changes, it was mentioned that the ELECTRON_SKIP_BINARY_DOWNLOAD env may be removed once the rfc change is implemented (it triggered upon postinstall; but as of electron v42 postinstall script is gone now). should mention of this be removed or altered from the docs? (as of now it is in advanced installation instructions section)
edit: there is also another postinstall script reference in the same section). should this be removed as well?

i'm happy to make a follow up PR on this :D

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 20, 2026
@jkleinsc
Copy link
Copy Markdown
Member

jkleinsc commented Mar 20, 2026

@jkleinsc jkleinsc merged commit 4e6324e into electron:main Mar 20, 2026
40 checks passed
@welcome
Copy link
Copy Markdown

welcome bot commented Mar 20, 2026

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link
Copy Markdown

release-clerk bot commented Mar 20, 2026

No Release Notes

@trop trop bot mentioned this pull request Mar 20, 2026
Merged
@trop
Copy link
Copy Markdown
Contributor

trop bot commented Mar 20, 2026

I have automatically backported this PR to "42-x-y", please check out #50405

@trop trop bot added in-flight/42-x-y and removed target/42-x-y PR should also be added to the "42-x-y" branch. labels Mar 20, 2026
@A-Star100 A-Star100 mentioned this pull request Mar 20, 2026
Merged
6 tasks
@trop trop bot added merged/42-x-y PR was merged to the "42-x-y" branch. and removed in-flight/42-x-y labels Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees

No one assigned

Labels

documentation 📓 merged/42-x-y PR was merged to the "42-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@A-Star100 @jkleinsc