Added Playwright E2E setup#101
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: de46666 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
… Electron 43, which Playwright 1.61 has never been tested against upstream. Documented the version constraint and how to check compatibility before the next Electron major upgrade.
…roduces there too. Added a temporary Windows-only CI step that launches the exe directly with the inspector flag and captures its output, and temporarily added windows-2022 to the matrix to bisect the runner image.
… replicates Playwright's exact flags, env and main argument to verify both inspector announcements, and the Windows test step runs with Playwright debug logging to trace the launch handshake. Removed windows-2022 from the matrix since both images fail identically.
…in E2E tests, since packaged builds load their bundled app on their own and the argument is one suspect for the Windows boot stall. Reworked the temporary Windows diagnostics into single-variable probes to bisect which launch condition prevents Electron from starting Chromium.
…directing the OS home directory, which should fix the Windows launch stall
…e Electron userData
Since pnpm 8.7 the content-addressable store keeps postinstall (side-effect) files as plain copies instead of symlinks (pnpm/pnpm#7691). dugite lays down git, whose git-core is ~145 symlinks to one binary; restoring that from the warm CI pnpm store flattened them into 145 full copies and roughly doubled the packaged macOS app (.dmg/.zip can't dedup them). Setting sideEffectsCache:false makes dugite re-extract git each install so the symlinks survive, while the pnpm store cache still speeds up everything else. The temporary git-core probe in CI stays until the next run confirms the fix.
The probe confirmed the macOS artifact doubling was pnpm flattening dugite's git-core symlinks from a warm store cache, now fixed by sideEffectsCache: false.
Nils-Kolvenbach
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.