[expressions] Add getValue API to lookup property value#13
Open
brsanthu wants to merge 1 commit intoelematic:mainfrom
Open
[expressions] Add getValue API to lookup property value#13brsanthu wants to merge 1 commit intoelematic:mainfrom
brsanthu wants to merge 1 commit intoelematic:mainfrom
Conversation
Author
|
@justinfagnani Appreciate it if you can review and add any feedback. |
brsanthu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts logic to get property value into separate API and uses that API to do property access. This enables users to override property access to support non-standard access patterns.
Fixes #12