Add Switch disabled state - #529
Open
Half-Shot wants to merge 6 commits into
Open
Conversation
Half-Shot
requested review from
MidhunSureshR and
dbkr
and removed request for
a team
July 10, 2026 11:27
Deploying compound-web with
|
| Latest commit: |
551fe01
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2c028c00.compound-web.pages.dev |
| Branch Preview URL: | https://hs-switch-disabled.compound-web.pages.dev |
Half-Shot
marked this pull request as draft
July 10, 2026 11:34
Member
Author
|
Not ready yet, needs to actually look disabled. |
Half-Shot
marked this pull request as ready for review
July 10, 2026 13:13
americanrefugee
requested changes
Jul 10, 2026
americanrefugee
left a comment
americanrefugee
left a comment
There was a problem hiding this comment.
Use the Disabled state for a Quick Action Button.
I just added an example of the Switch component that's disabled, which looks like this:
dbkr
approved these changes
Jul 10, 2026
americanrefugee
approved these changes
Jul 10, 2026
americanrefugee
left a comment
americanrefugee
left a comment
There was a problem hiding this comment.
Assuming that the border is applied to the selected disabled button, this LGTM
Member
Author
No it's reversed 🤦 Let's fix that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a
types-onlychange to Switch. A subtlety inReact.HTMLAttributesmeant that it didn't providedisabledand other useful params.Because this now allows you to disable the Switch, the styles need updating.