-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Unified media preview 2 - file body uses the previews #34890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Siriusmart
wants to merge
41
commits into
unified-previews/1-mediapreview-components
Choose a base branch
from
unified-previews/2-file-body-preview-tile
base: unified-previews/1-mediapreview-components
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 33 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
7f68661
file body uses new previews
Siriusmart 27fe1cc
collapsed and uncollapsed image tile
Siriusmart 4e75f83
using the new preview tiles in upload confirm dialog
Siriusmart c9d4eae
audio and video tag
Siriusmart 23311cc
slapped on the styles for url previews as well
Siriusmart eb22e50
remove old urlpreview code
Siriusmart ac265cc
fixed upload audio upload preview failing, and hide preview box when …
Siriusmart ad65da0
undo the removal of the legacy mediabody
Siriusmart 8ddb2be
undo removing the audio/voice message mediabody
Siriusmart bf2d791
fixed oxlint issues
Siriusmart 0a297fa
regenerate storybook screenshots
Siriusmart b878360
regenerate stuff for end to end tests
Siriusmart 8b8373f
jest and linter fix
Siriusmart 184c0b1
regenreated one image
Siriusmart 98149bb
show the new file preview in file search
Siriusmart 790949c
claude fixed end to end tests
Siriusmart 54fb7e5
pass lint
Siriusmart 386c20b
upload dialogue use tallbanner instead of full images
Siriusmart b878250
fixed tests
Siriusmart 4b34b5c
Merge branch 'unified-previews/1-mediapreview-components' into unifie…
Siriusmart 0d157a2
Merge branch 'unified-previews/1-mediapreview-components' into unifie…
Siriusmart f19805c
Cover the file preview tile and its view model
Siriusmart 7582050
Update the file panel screenshot to CI's rendering
Siriusmart c24d6e1
applied some reviews
Siriusmart 8b72b93
oxlint
Siriusmart ca67d01
Merge branch 'unified-previews/1-mediapreview-components' into unifie…
Siriusmart a44b4f9
docs for mediapreiewgroupviewmodel
Siriusmart dcaac3e
uses wrapper!
Siriusmart a2683b0
switch to userevent
Siriusmart 824dacf
renamed file name in test to more sensible thing
Siriusmart 1142736
use screen.getByRole instead of the destructed getByRole
Siriusmart 59b6fbd
made a new view model for mbodyfactory
Siriusmart 681a393
regenered one snapshot
Siriusmart 99bcd4b
Merge branch 'unified-previews/1-mediapreview-components' into unifie…
Siriusmart fa0dcbe
use aria label selector
Siriusmart 8800218
Merge branch 'unified-previews/2-file-body-preview-tile' of https://g…
Siriusmart 107885e
update changes from merge
Siriusmart 5adaf19
make bubble layout try to use as much width as the mediatile allow
Siriusmart c6b2072
fixed type issue
Siriusmart bb52722
shared component diff again
Siriusmart d4030e1
updated snapshot
Siriusmart File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+880 Bytes
(100%)
...b/playwright/snapshots/right-panel/file-panel.spec.ts/file-tiles-list-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.