Skip to content

Bypass the pnpm version check when installing the linked js-sdk #34906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nathanael-h wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Bypass the pnpm version check when installing the linked js-sdk #34906

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions scripts/docker-link-repos.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@
echo "Linking js-sdk"
git clone --depth 1 --branch $JS_SDK_BRANCH "$JS_SDK_REPO" js-sdk
cd js-sdk
# The cloned js-sdk may pin a different pnpm version than element-web. Corepack
# won't switch pnpm versions mid-process, so bypass the version check instead of
# failing. Exported (not just a CLI flag) so it also applies to the nested
# `pnpm build` spawned by js-sdk's `prepare` lifecycle script.
export npm_config_pm_on_fail=ignore

Check warning on line 28 in scripts/docker-link-repos.sh

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Environment variable 'npm_config_pm_on_fail' should use ALL_CAPS naming convention. 


See more on https://sonarcloud.io/project/issues?id=element-web&issues=AaBjDJ-bSButQIfScZZc&open=AaBjDJ-bSButQIfScZZc&pullRequest=34906
pnpm install
cd ../

Expand Down
Loading