Skip to content

SearchToolbar: Modernise, prepare for Gtk4#880

Merged
jeremypw merged 9 commits into
masterfrom
jeremypw/searchtoolbar/gtk4prep
Aug 7, 2025
Merged

SearchToolbar: Modernise, prepare for Gtk4#880
jeremypw merged 9 commits into
masterfrom
jeremypw/searchtoolbar/gtk4prep

Conversation

@jeremypw

@jeremypw jeremypw commented Jul 31, 2025

Copy link
Copy Markdown
Collaborator

View hiding whitespace change.

Any other Gtk4 prep needed?

Keeping as draft until pending release goes out

Comment thread src/Widgets/SearchToolbar.vala Outdated
Comment thread src/Widgets/SearchToolbar.vala Outdated
Comment thread src/Widgets/SearchToolbar.vala Outdated
@jeremypw

jeremypw commented Jul 31, 2025

Copy link
Copy Markdown
Collaborator Author

@danirabbit Can we clarify whether the license should be LGPL-3.0-only or LGPL-3.0-or-later? According to https://gnome.pages.gitlab.gnome.org/vte/gtk3/index.html the Gtk3 Vte library is the latter and https://gnome.pages.gitlab.gnome.org/vte/gtk4/index.html indicates the same for the Gtk4 library.

@danirabbit

Copy link
Copy Markdown
Member

@jeremypw it looks like this file was originally licensed only, but as a legal representative of elementary I approve relicensing as LGPL-3.0-or-later :)

@jeremypw

jeremypw commented Jul 31, 2025

Copy link
Copy Markdown
Collaborator Author

@danirabbit So does it need two license statements? One LGPL-3.0-or-later from 2025 and another for when it was LGPL-3.0-only?

@danirabbit

Copy link
Copy Markdown
Member

@jeremypw no we can just re-license it to LGPL-3.0-or-later since elementary holds copyright here

jeremypw and others added 4 commits July 31, 2025 19:52
Co-authored-by: Danielle Foré <danielle@elementary.io>
Co-authored-by: Danielle Foré <danielle@elementary.io>
@jeremypw jeremypw marked this pull request as ready for review August 7, 2025 18:16
@jeremypw jeremypw merged commit 8c28565 into master Aug 7, 2025
4 checks passed
@jeremypw jeremypw deleted the jeremypw/searchtoolbar/gtk4prep branch August 7, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants