Skip to content

ForegroundProcessDialog: Modernise/Gtk4 preparation #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremypw merged 7 commits into from
Aug 7, 2025
Merged

ForegroundProcessDialog: Modernise/Gtk4 preparation #882

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1a8c55d
Update header
jeremypw Jul 31, 2025
a466dd8
Correct license
jeremypw Jul 31, 2025
9c1cdbc
Copyright from 2011
jeremypw Jul 31, 2025
10bb146
Merge branch 'master' into jeremypw/foregroundprocessdialog/gtk4prep
jeremypw Jul 31, 2025
5d0f69b
Merge branch 'master' into jeremypw/foregroundprocessdialog/gtk4prep
jeremypw Aug 3, 2025
97f4697
Update ForegroundProcessDialog.vala
danirabbit Aug 4, 2025
3945afb
Merge branch 'master' into jeremypw/foregroundprocessdialog/gtk4prep
jeremypw Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 4 additions & 17 deletions src/Dialogs/ForegroundProcessDialog.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,8 @@
// -*- Mode: vala; indent-tabs-mode: nil; tab-width: 4 -*-
/*
* Copyright (c) 2011-2017 elementary LLC. (https://elementary.io)
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License version 3 as published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this program; if not, write to the
* Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
* Boston, MA 02110-1301 USA
*/
* SPDX-License-Identifier: LGPL-3.0-or-later
* SPDX-FileCopyrightText: 2011-2025 elementary, Inc. (https://elementary.io)

@danirabbit danirabbit Aug 1, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there's no code changes here, we shouldn't bump the copyright date

@jeremypw jeremypw Aug 3, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so you are happy there is are no code changes that need be/can be done before the port?

@danirabbit danirabbit Aug 4, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean the class is only 30 lines long, I can't see anything you could change here no 🤷‍♀️ I'm not sure I would really call this PR a GTK4 prep though, so much as just using the SPDX header

*/


public class Terminal.ForegroundProcessDialog : Granite.MessageDialog {
public string button_label { get; construct; }
Expand Down