Skip to content

ZoomOverlay: Modernize/gtk4 preparation#884

Merged
jeremypw merged 7 commits into
masterfrom
jeremypw/zoomoverlay/gtk4prep
Aug 8, 2025
Merged

ZoomOverlay: Modernize/gtk4 preparation#884
jeremypw merged 7 commits into
masterfrom
jeremypw/zoomoverlay/gtk4prep

Conversation

@jeremypw

Copy link
Copy Markdown
Collaborator

Any more prep needed?

Is there any problem changing license to LGPL for consistency with other files? Or should it be left as GPL?

@jeremypw

jeremypw commented Aug 1, 2025

Copy link
Copy Markdown
Collaborator Author

For some reason using Object () style creation when sub-classing Granite OverlayBar does not work as expected (even though compiles and runs). The construct property overlay is deprecated in granite but not in granite-7 for some reason.

Comment thread src/Widgets/ZoomOverlay.vala Outdated
* SPDX-License-Identifier: GPL-3.0-or-later
* SPDX-FileCopyrightText: 2024 elementary, Inc. (https://elementary.io)
* SPDX-License-Identifier: LGPL-3.0-or-later
* SPDX-FileCopyrightText: 2024-2025 elementary, Inc. (https://elementary.io)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there's no code changes here, we shouldn't change the copyright date

@jeremypw jeremypw marked this pull request as ready for review August 8, 2025 18:41
@jeremypw jeremypw enabled auto-merge (squash) August 8, 2025 18:41
@jeremypw jeremypw merged commit f330fd9 into master Aug 8, 2025
4 checks passed
@jeremypw jeremypw deleted the jeremypw/zoomoverlay/gtk4prep branch August 8, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants