Application: Gtk4 preparation#887
Merged
Merged
Conversation
danirabbit
requested changes
Aug 1, 2025
danirabbit
left a comment
danirabbit
left a comment
Member
There was a problem hiding this comment.
Just a tiny change and a question.
I think it makes sense to touch settings in a separate branch since that's not really related to this change
| } | ||
|
|
||
| if (!(Gdk.WindowState.FOCUSED in terminal.main_window.get_window ().get_state ())) { | ||
| if (!(get_active_window ().is_active)) { |
Member
There was a problem hiding this comment.
I didn't know this was already available in GTK3, very cool!
Co-authored-by: Danielle Foré <danielle@elementary.io>
Collaborator
Author
OK, so it can be done in Gtk3 before the port? |
Member
@jeremypw I think there's typically some finickyness about it that will need to be touched anyways, but it wouldn't hurt to get it a bit closer so there's less to do. I think it makes sense to do that in a separate branch though from this branch |
danirabbit
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some fairly substantive changes around
process-finishednotifications.TODO (maybe).
Changes need to be made around restoring window size which entail changing the settings schema. These could be done before or during the port and are left for another PR.
@danirabbit When is the correct time to make settings schema changes?