Skip to content

SettingsPopover: create ThemeCheckButton and use Settings action#889

Merged
jeremypw merged 3 commits into
masterfrom
danirabbit/settingspopover-themecheckbutton
Aug 3, 2025
Merged

SettingsPopover: create ThemeCheckButton and use Settings action#889
jeremypw merged 3 commits into
masterfrom
danirabbit/settingspopover-themecheckbutton

Conversation

@danirabbit

@danirabbit danirabbit commented Aug 1, 2025

Copy link
Copy Markdown
Member

Closes #885

GTK4 prep. Uses a stateful action from Settings.create_action for theme buttons and use CheckButton instead of RadioButton. Can be rebase merged if desired

@danirabbit danirabbit requested a review from jeremypw August 1, 2025 19:58
@danirabbit danirabbit changed the title Danirabbit/settingspopover themecheckbutton SettingsPopover: create ThemeCheckButton and use Settings action Aug 1, 2025

@jeremypw jeremypw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as before

@jeremypw jeremypw merged commit a531cdd into master Aug 3, 2025
4 checks passed
@jeremypw jeremypw deleted the danirabbit/settingspopover-themecheckbutton branch August 3, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants