Skip to content

Fix some issues with running under tmux #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremypw merged 5 commits into from
Jan 25, 2026
+4 −5
Merged

Fix some issues with running under tmux #946

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fc8d611
Prevent corruption of old_loc under tmux
jeremypw Nov 20, 2025
979cd19
Change accel for scroll to command
jeremypw Nov 20, 2025
9dbdeb3
Change scroll_to_command accel, lose unused
jeremypw Nov 20, 2025
32013f3
Merge branch 'main' into jeremypw/fix-scroll-to-command-accel
jeremypw Dec 29, 2025
40cf575
Merge branch 'main' into jeremypw/fix-scroll-to-command-accel
zeebok Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/Widgets/TerminalWidget.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ namespace Terminal {
public const string[] ACCELS_RESET = { "<Control><Shift>K", null };
public const string[] ACCELS_PASTE = { "<Control><Shift>V", null };
public const string[] ACCELS_RELOAD = { "<Control><Shift>R", "<Ctrl>F5", null };
public const string[] ACCELS_SCROLL_TO_COMMAND = { "<Alt>Up", null };
public const string[] ACCELS_SELECT_ALL = { "<Control><Shift>A", null };
// Specify zooming shortcuts for use by tooltips in SettingsPopover. We don't use actions for this.
public const string[] ACCELS_ZOOM_DEFAULT = { "<control>0", "<Control>KP_0", null };
Expand Down Expand Up @@ -199,7 +198,7 @@ namespace Terminal {
);

var scroll_to_command_shortcut = new Gtk.Shortcut (
new Gtk.KeyvalTrigger (Gdk.Key.Up, ALT_MASK),
new Gtk.KeyvalTrigger (Gdk.Key.U, ALT_MASK),
new Gtk.NamedAction ("term.scroll-to-command")
);

Expand Down Expand Up @@ -670,8 +669,9 @@ namespace Terminal {
feed_command (command);
}

private string old_loc = "";
public void reload () {
var old_loc = get_shell_location ();
old_loc = get_shell_location ();
confirm_kill_fg_process (
_("Are you sure you want to reload this tab?"),
_("Reload"),
Expand Down Expand Up @@ -1097,11 +1097,10 @@ namespace Terminal {
}

private void scroll_to_command (GLib.SimpleAction action, GLib.Variant? parameter) {
//Note. This does not work when running under `tmux` - native scrolling is suppressed in a tmux pane
long row, delta;

get_cursor_position (null, out row);
delta = remembered_position - row;

vadjustment.value += (int) delta + height_request / get_char_height () - 1;
action.set_enabled (false); // Repeated presses are ignored
}
Expand Down