Cleanup: explicit private modifier and remove dead code#995
Merged
Conversation
danirabbit
reviewed
Feb 18, 2026
lenemter
force-pushed
the
lenemter/cleanup-7
branch
from
36c38ff to
3669828
Compare
danirabbit
reviewed
Feb 18, 2026
danirabbit
approved these changes
Feb 18, 2026
danirabbit
left a comment
danirabbit
left a comment
Member
There was a problem hiding this comment.
Looks good except for the one comment :)
Collaborator
|
This will conflict with #998, which alters a function that this PR removes. |
jeremypw
added
the
Status: Blocked
Collaborator
|
Blocking until conflict resolved and I don't want to merge anything that will require amending translations of the metainfo until after release v8.0.0, unless critical. We can do a quick follow up release. @danirabbit Will it require re-translation of metainfo if only an |
Member
|
@jeremypw no |
danirabbit
removed
the
Status: Blocked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.