Allow using std::string_view instead of ErlNifBinary#4
Merged
Conversation
Since `std::string_view` integrates better with the C++ ecosystem and is available in C++17, this commit ensures that it is available as an encodable and decodable type equivalent to `ErlNifBinary` while keeping `ErlNifBinary` available if needed.
jonatanklosko
left a comment
jonatanklosko
left a comment
Member
There was a problem hiding this comment.
Hey @brodeuralexis, this is great, thank you! I was not aware of std::string_view, I think we could actually skip encoder/decoder for ErlNifBinary, but let's keep it to avoid breaking changes (and it doesn't hurt to have it).
jonatanklosko
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
std::string_viewintegrates better with the C++ ecosystem and is available in C++17, this commit ensures that it is available as an encodable and decodable type equivalent toErlNifBinarywhile keepingErlNifBinaryavailable if needed.