Add python lockfile creation to new releases#3041
Open
akchinSTC wants to merge 1 commit into
Open
Conversation
akchinSTC
marked this pull request as ready for review
December 12, 2022 17:52
kevin-bates
reviewed
Dec 13, 2022
Member
There was a problem hiding this comment.
Is something flagging these as necessary? Seems like write_error() resolution would be satisfied by the mixin.
Member
Author
There was a problem hiding this comment.
CodeQL is showing warnings for this. seems they want you to explicitly define which method we use despite it always resolving from left to right in terms of inheritance. Guess its for clarity.
akchinSTC
force-pushed
the
lockfile
branch
2 times, most recently
from
December 15, 2022 19:02
0eb7f0d to
85e9afe
Compare
Signed-off-by: Alan Chin <akchin@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependent on #3038
Per LFAI onboarding, releases need to be reproducible. In addition to the yarn.lock file, the release process will now include a python lockfile (requirements.txt) generated at build time which includes explicit listing direct and indirect dependencies and their hash signatures.
What changes were proposed in this pull request?
How was this pull request tested?
Developer's Certificate of Origin 1.1