Add Appearance Capability to Advertisement Builder (and refactor)#289
Open
AdinAck wants to merge 2 commits intoembassy-rs:masterfrom
Open
Add Appearance Capability to Advertisement Builder (and refactor)#289AdinAck wants to merge 2 commits intoembassy-rs:masterfrom
AdinAck wants to merge 2 commits intoembassy-rs:masterfrom
Conversation
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently appearance data can be added with
AdvertisementBuilder::raw(), this PR adds a dedicatedAdvertisementBuilder::appearance()method along with an exhaustive list of all appearance AD types according to the yaml file.Additionally I refactored the advertisement builder to be more organized, and give AD types more consistency.