model: Add Byrne-Embed model implementation#4847
Merged
KennethEnevoldsen merged 3 commits intoJun 30, 2026
Merged
Conversation
Samoed
reviewed
Jun 22, 2026
|
|
||
| self.model_name = model | ||
| self.device = device | ||
| local = snapshot_download(repo_id=model, revision=revision) |
Member
There was a problem hiding this comment.
You shoudn't use snapshot download. Update to use trust_remote_code or create a library with code
Contributor
Author
|
Thank you, and apologies for the snapshot_download approach — that was the wrong call. I've fixed it: the loader now uses
Apologies again for the back-and-forth — my ISP is currently blocking the mteb docs site, so I've been navigating the contributing guide on my phone while working on my computer, which made me miss the intended pattern at first. Please let me know if anything else needs adjusting. |
Samoed
approved these changes
Jun 22, 2026
Co-authored-by: Roman Solomatin <samoed.roman@gmail.com>
KennethEnevoldsen
approved these changes
Jun 30, 2026
8b8f169
into
embeddings-benchmark:main
11 of 13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a model implementation for Quazim0t0/Byrne-Embed, a compact 85M sentence-embedding model, per the adding-a-model guide.
mteb/models/model_implementations/byrne_models.pyByrneEmbedModelsubclassesAbsEncoderand implementsencode(); itsnapshot_downloads the model repo (which bundles its self-containedbyrne_embedder.pyloader + modeling code) and produces 768-dim unit-norm embeddings.ModelMetaregistered with revision matching the submitted results (b1dd734…).Verified the meta validates and registers in MODEL_REGISTRY locally.