Skip to content

model: Add Byrne-Embed model implementation#4847

Merged
KennethEnevoldsen merged 3 commits into
embeddings-benchmark:mainfrom
SeanceTable:add-byrne-embed-model
Jun 30, 2026
Merged

model: Add Byrne-Embed model implementation#4847
KennethEnevoldsen merged 3 commits into
embeddings-benchmark:mainfrom
SeanceTable:add-byrne-embed-model

Conversation

@SeanceTable

Copy link
Copy Markdown
Contributor

Adds a model implementation for Quazim0t0/Byrne-Embed, a compact 85M sentence-embedding model, per the adding-a-model guide.

Verified the meta validates and registers in MODEL_REGISTRY locally.


self.model_name = model
self.device = device
local = snapshot_download(repo_id=model, revision=revision)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shoudn't use snapshot download. Update to use trust_remote_code or create a library with code

@SeanceTable

Copy link
Copy Markdown
Contributor Author

Thank you, and apologies for the snapshot_download approach — that was the wrong call. I've fixed it: the loader now uses trust_remote_code only.

  • The model repo (Quazim0t0/Byrne-Embed) is now a proper custom-code transformers model: the projection head is fused into the weights and modeling_byrne_embed.py is fully self-contained, so it loads with a plain AutoModel.from_pretrained(..., trust_remote_code=True) (and AutoTokenizer likewise).
  • ByrneEmbedModel no longer does any snapshot_download/sys.path manipulation — see the updated byrne_models.py.
  • Verified end-to-end: clean cache → AutoModel/AutoTokenizer via trust_remote_code → encode produces the expected embeddings.
  • The revision is pinned to af905dd and the results PR (Add Byrne-Embed (Quazim0t0/Byrne-Embed) MTEB(eng, v2) results results#577) has been updated to the same revision (embeddings are identical to the prior weights, parity 1.0).

Apologies again for the back-and-forth — my ISP is currently blocking the mteb docs site, so I've been navigating the contributing guide on my phone while working on my computer, which made me miss the intended pattern at first. Please let me know if anything else needs adjusting.

Comment thread mteb/models/model_implementations/byrne_models.py Outdated
Co-authored-by: Roman Solomatin <samoed.roman@gmail.com>
@KennethEnevoldsen KennethEnevoldsen changed the title Add Byrne-Embed model implementation model: Add Byrne-Embed model implementation Jun 30, 2026
@KennethEnevoldsen KennethEnevoldsen enabled auto-merge (squash) June 30, 2026 13:50
@KennethEnevoldsen KennethEnevoldsen merged commit 8b8f169 into embeddings-benchmark:main Jun 30, 2026
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants