[CLEANUP] remove manually annoted legacy code#1520
Open
chancancode wants to merge 1 commit intomasterfrom
Open
[CLEANUP] remove manually annoted legacy code#1520chancancode wants to merge 1 commit intomasterfrom
chancancode wants to merge 1 commit intomasterfrom
Conversation
These are slightly riskier in that you'd have to take the comment author's word for it, as the proposed code was never execrised or tested in the real world (unlike in #20798, where, if there were no bugs in the branchgin, we should have been running the correct branch all along and for a while now). But I manually audited these spots and to my knowledge they seemed safe.
chancancode
commented
Nov 22, 2024
| const fallbackRegistry = Application.buildRegistry(namespace); | ||
| // TODO: only do this on Ember < 3.13 | ||
| // @ts-ignore: this is private API. | ||
| fallbackRegistry.register('component-lookup:main', Ember.ComponentLookup); |
Member
Author
There was a problem hiding this comment.
This hasn't done anything for a long time now, and in any case this would be re-registering the same thing that was already there.
chancancode
commented
Nov 22, 2024
| // | ||
| // import { registerWaiter } from '@ember/test'; | ||
| Ember.Test.registerWaiter(this, this.isReady); | ||
| registerWaiter(this, this.isReady); |
Member
Author
There was a problem hiding this comment.
There are other places in the codebase that already uses this pattern
chancancode
commented
Nov 22, 2024
| this._super.apply(this, arguments); | ||
| // must be called with `Ember.Test` as context for Ember < 2.8 | ||
| Ember.Test.unregisterWaiter(this, this.isReady); | ||
| unregisterWaiter(this, this.isReady); |
Member
Author
There was a problem hiding this comment.
There are other places in the codebase that already uses this pattern
NullVoxPopuli
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are slightly riskier in that you'd have to take the comment author's word for it, as the proposed code was never execrised or tested in the real world (unlike in #20798, where, if there were no bugs in the branchgin, we should have been running the correct branch all along and for a while now).
But I manually audited these spots and to my knowledge they seemed safe.