Include custom ScaleKernel#221
Merged
Merged
Conversation
AVHopp
force-pushed
the
feature/scale_kernel
branch
from
236aed5 to
78695ae
Compare
Collaborator
Author
|
@Scienfitz @AdrianSosic just a quick ping that the |
AdrianSosic
requested changes
Apr 29, 2024
AdrianSosic
left a comment
AdrianSosic
left a comment
Collaborator
There was a problem hiding this comment.
Hi @AVHopp, here the first batch of comments
AdrianSosic
reviewed
Apr 29, 2024
Scienfitz
reviewed
May 3, 2024
Scienfitz
reviewed
May 3, 2024
AVHopp
force-pushed
the
feature/scale_kernel
branch
2 times, most recently
from
7862ab3 to
ba2e41e
Compare
Scienfitz
reviewed
May 6, 2024
AVHopp
commented
May 8, 2024
AdrianSosic
requested changes
May 13, 2024
The `filter_attributes` approach is going to be replaced in an upcoming PR anyway.
AdrianSosic
force-pushed
the
feature/scale_kernel
branch
from
36897c7 to
b34529c
Compare
AdrianSosic
force-pushed
the
feature/scale_kernel
branch
from
f151de1 to
89b565f
Compare
AdrianSosic
approved these changes
May 13, 2024
AdrianSosic
left a comment
AdrianSosic
left a comment
Collaborator
There was a problem hiding this comment.
I think everything's ready for merge from my side now 🚀
AVHopp
force-pushed
the
feature/scale_kernel
branch
from
43c076c to
bcab06a
Compare
AdrianSosic
force-pushed
the
feature/scale_kernel
branch
from
a88a533 to
ce6590c
Compare
Scienfitz
approved these changes
May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces custom ScaleKernels. It is currently based on #219 and will be properly rebased and moved out of draft state once that PR is merged.