Skip to content

Add GPU testing workflows and add gpu tox configuration#635

Merged
AdrianSosic merged 15 commits into
mainfrom
fix/change-benchmark-env-creation-and-add-gpu-tox
Oct 6, 2025
Merged

Add GPU testing workflows and add gpu tox configuration#635
AdrianSosic merged 15 commits into
mainfrom
fix/change-benchmark-env-creation-and-add-gpu-tox

Conversation

@fabianliebig

Copy link
Copy Markdown
Collaborator

This PR adds a dedicated Tox environment for GPU-related tests and one manual workflow as well as additional steps to regular and CI for installing and starting those tests. At the moment, they are only executed if triggered manually and if core tests have passed. Support for other triggers is WIP. Additionally, I've changed the Benchmark installation to UV and added terminal outputs of standard resource commands for CPU, RAM and so on.

@fabianliebig fabianliebig self-assigned this Sep 8, 2025
@fabianliebig fabianliebig marked this pull request as ready for review September 8, 2025 05:47

@AVHopp AVHopp left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of comments.

Comment thread .github/workflows/benchmark.yml
Comment thread .github/workflows/benchmark.yml
Comment thread .github/workflows/benchmark.yml
Comment thread tox.ini Outdated
Comment thread .github/workflows/regular.yml
Comment thread .github/workflows/gpu_tests.yml Outdated
Comment thread .github/workflows/gpu_tests.yml Outdated
Comment thread .github/workflows/benchmark.yml
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/regular.yml Outdated
@fabianliebig fabianliebig deleted the fix/change-benchmark-env-creation-and-add-gpu-tox branch September 10, 2025 09:24
@fabianliebig fabianliebig restored the fix/change-benchmark-env-creation-and-add-gpu-tox branch September 10, 2025 09:24
@fabianliebig fabianliebig reopened this Sep 10, 2025
Comment thread .github/workflows/gpu_tests.yml Outdated
Comment thread .github/workflows/gpu_tests.yml Outdated
Comment thread .github/workflows/gpu_tests.yml Outdated
Comment thread .github/workflows/regular.yml
Comment thread .github/workflows/gpu_tests.yml Outdated
Copilot AI review requested due to automatic review settings September 11, 2025 10:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds GPU testing capabilities to the project by introducing a dedicated Tox environment for GPU tests and workflow configurations. The changes include manual workflow triggers for GPU testing, system information outputs for benchmarking, and modernization of the benchmark installation process.

  • Adds a new gputest Tox environment for GPU-specific testing
  • Introduces manual GPU testing workflows that require core tests to pass first
  • Modernizes benchmark installation by switching from pip to uv package manager

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tox.ini Adds gputest environment configuration with GPU availability check
.github/workflows/regular.yml Adds GPU testing job triggered by manual workflow dispatch
.github/workflows/gpu_tests.yml New dedicated workflow for GPU tests with AWS Lambda runner provisioning
.github/workflows/ci.yml Adds GPU testing job to CI workflow with manual trigger
.github/workflows/benchmark.yml Adds system information output and migrates to uv package manager

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread .github/workflows/ci.yml Outdated
Comment thread tox.ini
Comment thread .github/workflows/ci.yml

@AVHopp AVHopp left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only thing to do is to remove the single precision env variables, but there is already a comment for that.

@AdrianSosic AdrianSosic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @fabianliebig, for taking the initiative here. I've gone through the changes and comments by others and there's no obvious reason to block anything from my side. However, it's one of the typical fabian knows this stuff so much better than me PRs that I'm more or less trusting you blindly here and will only potentially complain once I actually start using it and encounter issues, i.e. once our GPU code is ready 😄

@fabianliebig

Copy link
Copy Markdown
Collaborator Author

Thanks, @fabianliebig, for taking the initiative here. I've gone through the changes and comments by others and there's no obvious reason to block anything from my side. However, it's one of the typical fabian knows this stuff so much better than me PRs that I'm more or less trusting you blindly here and will only potentially complain once I actually start using it and encounter issues, i.e. once our GPU code is ready 😄

Thanks for the review and trust :). Please don't hesitate to reach out anytime if you run into problems or even just have questions. I'm happy to help troubleshoot. Working with GPU can be quite messy and there are nearly always issues and synergies that weren't foreseeable :D

I think if the pipeline code and TOX environment work for you, and since Torch can already detect the GPU, that's a good starting point to explore GPU usage :) Feel free to merge once you think it fits and as said ping me if you need me :D

@AdrianSosic AdrianSosic force-pushed the fix/change-benchmark-env-creation-and-add-gpu-tox branch from 6e656c7 to c5a60c2 Compare October 6, 2025 08:59
@AdrianSosic AdrianSosic merged commit 578a269 into main Oct 6, 2025
10 of 12 checks passed
@AdrianSosic AdrianSosic deleted the fix/change-benchmark-env-creation-and-add-gpu-tox branch October 6, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants