Fix README links#827
Open
AdrianSosic wants to merge 3 commits into
Open
Conversation
AdrianSosic
commented
Jun 12, 2026
AdrianSosic
commented
Collaborator
- Fixes the navigation links
- Turn mentioned code components into links (clickable is always better than non-clickable)
AdrianSosic
added
bug
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates project documentation links in README.md and also introduces a new Gaussian Process feature (GaussianProcessSurrogate.posterior_mean_function) intended to reuse a trained GP’s posterior mean as the mean function for a newly-fitted GP (with accompanying tests and a changelog entry).
Changes:
- Fix and restructure top-level README navigation links; convert referenced components in the README to clickable API-doc links.
- Add
GaussianProcessSurrogate.posterior_mean_functionand refactor GP input/outcome transform construction into helpers. - Add unit tests covering posterior-mean correctness across differing bounds; add an Unreleased changelog entry.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
README.md |
Adjusts navigation links and converts referenced components to documentation hyperlinks. |
baybe/surrogates/gaussian_process/core.py |
Adds posterior_mean_function and refactors input/outcome transform creation. |
baybe/surrogates/gaussian_process/components/mean.py |
Minor module-level change (GC collection pattern). |
tests/test_gp.py |
Adds tests for posterior mean behavior (bounds-equality and not-fitted error). |
CHANGELOG.md |
Adds Unreleased entry documenting the new GP method. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AVHopp
reviewed
Jun 17, 2026
AVHopp
approved these changes
Jun 22, 2026
AVHopp
left a comment
AVHopp
left a comment
Collaborator
There was a problem hiding this comment.
I think one additional link should be changed, other than that everything seems to work
| <ul> | ||
| <li>Capture relationships between categories via <a href="https://emdgroup.github.io/baybe/stable/components/parameters.html#customdiscreteparameter">custom encodings for categorical</a> data.</li> | ||
| <li>Use built-in <a href="https://emdgroup.github.io/baybe/stable/components/parameters.html#substanceparameter">chemical encodings</a> for chemistry-related parameters.</li> | ||
| <li>Add mechanistic process understanding via <a href="https://emdgroup.github.io/baybe/stable/components/surrogates.html#using-custom-models">custom surrogate</a> models.</li> |
Collaborator
There was a problem hiding this comment.
@AdrianSosic could you also change this link here? This now only directs we to the top of the Surrogates, probably because the part after the #... is not up to date anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.