Skip to content

Update emqtt_frame.erl #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabrielmancini wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update emqtt_frame.erl #281

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf14dc8
Update emqtt_frame.erl
gabrielmancini Mar 27, 2025
72ef791
Merge branch 'emqx:master' into master
gabrielmancini Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/emqtt_frame.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,10 +437,10 @@ parse_variable_byte_integer(<<0:1, Len:7, Rest/binary>>, Multiplier, Value) ->

parse_topic_filters(subscribe, Bin) ->
[{Topic, #{rh => Rh, rap => Rap, nl => Nl, qos => QoS}}
|| <<Len:16/big, Topic:Len/binary, _:2, Rh:2, Rap:1, Nl:1, QoS:2>> <= Bin];
|| <<_:8, Len:16/big, Topic:Len/binary, _:2, Rh:2, Rap:1, Nl:1, QoS:2>> <= Bin];

@zmstone zmstone Mar 31, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot seem to find why there is one leading byte before the string length.


parse_topic_filters(unsubscribe, Bin) ->
[Topic || <<Len:16/big, Topic:Len/binary>> <= Bin].
[Topic || <<_:8, Len:16/big, Topic:Len/binary>> <= Bin].

parse_reason_codes(Bin) ->
[Code || <<Code>> <= Bin].
Expand Down