Skip to content

Scope mixercalc CSS selectors to prevent PID tab style bleed-through#552

Merged
nerdCopter merged 1 commit intoemuflight:masterfrom
nerdCopter:fix/mixercalc-css-scope
Apr 12, 2026
Merged

Scope mixercalc CSS selectors to prevent PID tab style bleed-through#552
nerdCopter merged 1 commit intoemuflight:masterfrom
nerdCopter:fix/mixercalc-css-scope

Conversation

@nerdCopter
Copy link
Copy Markdown
Member

@nerdCopter nerdCopter commented Apr 12, 2026

This PR scopes the mixer calculator CSS table header and cell styles to the static tab container (#tab-static) so they no longer apply globally across all tabs. This fixes broken PID tab header styling after visiting the motor-mix tab.

Summary by CodeRabbit

  • Style
    • Refined CSS styling scope to prevent unintended style application outside the intended container.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 77e7a8b5-b058-4eac-a935-43f616dd216a

📥 Commits

Reviewing files that changed from the base of the PR and between b67b9e9 and 83eea8f.

📒 Files selected for processing (1)
  • src/css/tabs/mixercalc.css

📝 Walkthrough

Walkthrough

CSS selectors in mixercalc.css were scoped to apply only within the #tab-static container. Table styling rules for th and td elements no longer apply globally, preventing unintended style leakage outside the target container.

Changes

Cohort / File(s) Summary
CSS Selector Scoping
src/css/tabs/mixercalc.css
Narrowed th and td selectors to be container-specific (#tab-static th and #tab-static td) to limit style scope and prevent global table element styling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: scoping CSS selectors to prevent style bleed-through, which directly matches the core purpose of the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nerdCopter nerdCopter merged commit 53dc6bb into emuflight:master Apr 12, 2026
8 checks passed
@nerdCopter nerdCopter deleted the fix/mixercalc-css-scope branch April 12, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant