test(cs/lpp): mirror lpc write-CB test parity incl. partial write - #250
Open
andig wants to merge 1 commit into
Open
test(cs/lpp): mirror lpc write-CB test parity incl. partial write#250andig wants to merge 1 commit into
andig wants to merge 1 commit into
Conversation
lpp's Test_loadControlWriteCB had no assertions and no partial-write case, unlike lpc. Bring it to parity: assert eventCalled per step and add the partial write case (CmdControl.Partial) so partial handling is consistently covered across both control-system usecases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sthelen-enqs
self-requested a review
August 17, 2026 11:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
usecases/cs/lppTest_loadControlWriteCBhad no assertions and lacked the partial-write case present in the equivalentcs/lpctest. This brings lpp to parity with lpc:eventCalledat each step (invalid msg, empty data, no matching limit, matching limit)Filter[].CmdControl.Partial) so partial-write handling is consistently covered across both control-system usecasesWhy
Production write callbacks in lpc/lpp are identical, but only lpc verified partial-write behavior. Test coverage now matches.
Scope
Test-only. No production change.
go test ./usecases/cs/lpp/passes.🤖 Generated with Claude Code