chore: remove redundant nil checks - #258
Open
andig wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
len()is defined on nil slices and returns0, so the paired== nilcheck is redundant. Likewise, ranging over a nil slice is a no-op, so the guard around it adds nothing.features/internal/deviceconfiguration.go—descriptions == nil || len(descriptions) == 0usecases/cs/lpc/usecase.go—data.LoadControlLimitData == nil || len(data.LoadControlLimitData) == 0usecases/cs/lpp/usecase.go— samefeatures/internal/electricalconnection.go—if set.Range != nil { for _, rangeItem := range set.Range {guard removedThe outer
data == nilchecks are kept — those guard the pointer dereference.Found with an AST pass over the whole repo rather than a text search, so the set is complete for these shapes:
x == nil || len(x) == 0andx != nil && len(x) > 0in either operand order and including the< 1/<= 0/!= 0/>= 1spellings, plus nil guards wrapping arangeorappendon the same value.🤖 Generated with Claude Code