fixed spelling#24
Open
khushi-parikh wants to merge 3 commits into
Open
Conversation
|
✔️ Deploy Preview for vibrant-goldberg-bb117d ready! 🔨 Explore the source changes: b2ce0c7 🔍 Inspect the deploy log: https://app.netlify.com/sites/vibrant-goldberg-bb117d/deploys/6169dee83356970007ff0d92 😎 Browse the preview: https://deploy-preview-24--vibrant-goldberg-bb117d.netlify.app |
enjeck
requested changes
Oct 13, 2021
enjeck
left a comment
enjeck
left a comment
Owner
There was a problem hiding this comment.
Hi @khushi-parikh. You also have to fix the spelling in the src/data/logos.js file.
Thanks
Author
|
@enjeck sorry that i missed it before, i have corrected it now. |
enjeck
requested changes
Oct 15, 2021
enjeck
left a comment
enjeck
left a comment
Owner
There was a problem hiding this comment.
There's one more tiny change required
| @@ -188,7 +188,7 @@ export const Logos = [ | |||
| `Minimal professional black and white Ying Yang logo in square shape. | |||
Author
|
@enjeck changed 👍 |
Author
|
can it please be merged so that it can count in my contribution to hacktoberfest? |
Owner
|
@khushi-parikh Sure, I'll merge it later. For now, I'll add the hacktoberfest-accepted label. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this closes issue #23. please merge this under hacktoberfest.