Open
Conversation
added 2 commits
September 29, 2023 22:47
This commit adds test case for OwnedResolver and moves the dnsName utility function in test-utils folder from PublicResolver and renames it nameToHex for sharing with OwnedResolver
Arachnid
reviewed
Oct 6, 2023
| function hexEncodeTXT(keys) { | ||
| return '0x' + packet.answer.encode(keys).toString('hex') | ||
| } | ||
| // resolves to a hexadecimal address from a name |
Member
There was a problem hiding this comment.
What's the purpose of rewriting this instead of using dnsName?
Author
There was a problem hiding this comment.
Thanks for the question @Arachnid. Actually, the "dnsName" function is renamed to the "nameToHex" function. Also, I have moved this "nameToHex" function to the utils section for sharing between the newly created TestOwnedResolver and the old TestPublicResolver.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #243