Skip to content

from Xyz import to_text can import extension methods#14949

Merged
mergify[bot] merged 7 commits intodevelopfrom
wip/jtulach/ImportExtensionMethodByName10796
Apr 9, 2026
Merged

from Xyz import to_text can import extension methods#14949
mergify[bot] merged 7 commits intodevelopfrom
wip/jtulach/ImportExtensionMethodByName10796

Conversation

@JaroslavTulach
Copy link
Copy Markdown
Member

@JaroslavTulach JaroslavTulach commented Apr 9, 2026

Pull Request Description

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Scala,
    Java,
  • Unit tests have been written where possible.

@JaroslavTulach JaroslavTulach changed the title Import extension methods by name from Xyz import to_text can import extension methods Apr 9, 2026
Copy link
Copy Markdown
Contributor

@4e6 4e6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good overall. I would also add tests verifying that from X import all hiding Y correctly handle conversions

@JaroslavTulach
Copy link
Copy Markdown
Member Author

Good overall. I would also add tests verifying that from X import all hiding Y correctly handle conversions

Done in 1f88c29 - yet the handling of from imports is far from ideal. But I'd rather leave that for another PR.

@JaroslavTulach JaroslavTulach added the CI: Ready to merge This PR is eligible for automatic merge label Apr 9, 2026
@mergify mergify bot merged commit 33b5c47 into develop Apr 9, 2026
83 of 85 checks passed
@mergify mergify bot deleted the wip/jtulach/ImportExtensionMethodByName10796 branch April 9, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: Ready to merge This PR is eligible for automatic merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Importing extension methods ignores hiding and ignores methods imported by name (only all works)

2 participants