[auth] Addition of new icons / Update to existing icons#9789
[auth] Addition of new icons / Update to existing icons#9789millia-rage wants to merge 22 commits intoente-io:mainfrom
Conversation
Custom Icon for Nintendo updated, removing the unnecessary red background.
Removing the hex value for Capcom, so that the icon appears in two colors as intended.
Added .svg file for ESL Gaming (refer to https://brand.eslfaceitgroup.com/d/PUMsQ8isBnFF/esl-brand-playbook#/visual-fundamentals/logo)
Two separate entires for Mozilla and Firefox exist now.
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 812b76360c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4fc5fa9f1b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 09df02b8b0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Can we revert the change for mozilla icon and instead add this new one as alt icon? |
|
I triple checked and the icon mozilla.svg is not used on any Firefox or Mozilla product anymore. However, I have now also re-added the deprecated icon as an alt, in case people prefer it. |
3 participants
Additions
New icons have been added for:
Updates
custom-icons.jsonfor it to properly display in blue and yellow.MozillaOld).Resources for each icon
path)