Conversation
# Conflicts: # mobile/apps/photos/lib/main.dart # mobile/apps/photos/plugins/ente_feature_flag/lib/src/service.dart
Both onAppForeground and _waitForGraceWindowExpiration now snapshot DateTime.now() before yielding to the event loop, ensuring concurrent sync() lock acquisitions are never accidentally released.
Merge ios_background_handoff.dart into BgTaskUtils (removes 8 delegation methods and a separate module). Inline BackgroundRunHelper lease logic into main.dart as flat functions. Replace IOSBackgroundProcessingSchedule class with a Dart record. Remove BackgroundSkipReason enum in favor of inline log messages. Deletes: background_run_helper.dart, ios_background_handoff.dart, background_run_helper_test.dart (tested a now-deleted class).
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e165009bf
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
1 participant
Description
Tests