Skip to content

Tiny adjustments to output - #1342

Closed
toothbrush wants to merge 2 commits into
mainfrom
20260603-adjust-login-prompt
Closed

Tiny adjustments to output#1342
toothbrush wants to merge 2 commits into
mainfrom
20260603-adjust-login-prompt

Conversation

@toothbrush

@toothbrush toothbrush commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

https://entire.io/gh/entireio/cli/trails/496

Description

Very small prettification of things that were bothering me:

  • mise run dev:publish - i use it all the time and i like it when it tells me what it's installed
  • The login flow - i found i always had to read twice, because the URL and the "press Enter" prompt blurred together a bit. Now i think it's very readable:
$ entire login
Device code: 5XXS-2XXB
Login URL:   https://us.auth.entire.io/cli/auth?user_code=5XXS-2XXB

Press Enter to open in browser...

Waiting for approval... ✅ login complete.

Note

Low Risk
Copy and dev-task script changes only; no auth, token, or install logic changes.

Overview
Polishes entire login terminal output so the device code, labeled Login URL, and Enter prompt are on separate lines (interactive and non-interactive paths share the same URL label). The approval wait line stays on one line so a checkmark can appear inline, and success is shown as ✅ login complete. on that line instead of a separate sentence.

mise run dev:publish now installs entire and git-remote-entire in a loop and prints an Installed: line per binary to stderr.

Reviewed by Cursor Bugbot for commit bebe495. Configure here.

I found the "Press Enter to..." prompt got a bit lost and i always had
to double-take.  Tried to neaten it a tiny bit.
I like seeing what has been installed.  Makes me less nervous.
Copilot AI review requested due to automatic review settings June 3, 2026 08:50
@toothbrush
toothbrush requested a review from a team as a code owner June 3, 2026 08:50

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit bebe495. Configure here.

Comment thread cmd/entire/cli/login.go
}

fmt.Fprintln(outW, "Login complete.")
fmt.Fprint(outW, " ✅ login complete.")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Login stdout breaks integration tests

Medium Severity

Stdout now prints Login URL: and login complete. with different casing/format, but integration_test/login_test.go still waits for an Approval URL: line and asserts Login complete.. TestLogin_SavesTokenAfterApproval will time out in waitForLoginPrompt and fail the completion check.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit bebe495. Configure here.

Comment thread cmd/entire/cli/login.go
}

fmt.Fprintln(outW, "Login complete.")
fmt.Fprint(outW, " ✅ login complete.")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success message lacks trailing newline

Low Severity

Successful login ends with fmt.Fprint of the completion text without a final newline, so the shell prompt can appear on the same line as login complete. and piped or logged output may not terminate with a line break.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit bebe495. Configure here.

@toothbrush toothbrush closed this Jun 3, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request makes small UX-oriented output tweaks in the CLI and the local dev publish task, aiming to make entire login output more readable and to surface what mise run dev:publish installed.

Changes:

  • Adjusts entire login output to use a labeled “Login URL” line and changes the completion messaging.
  • Updates mise run dev:publish to install binaries in a loop and print an “Installed:” line per binary.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
mise-tasks/dev/publish Installs entire and git-remote-entire individually and echoes an installed message per binary.
cmd/entire/cli/login.go Reformats device-login output (URL label / spacing) and changes “waiting” + “complete” messaging.

Comment thread cmd/entire/cli/login.go
}
} else {
fmt.Fprintf(outW, "Approval URL: %s\n", approvalURL)
fmt.Fprintf(outW, "Login URL: %s\n\n", approvalURL)
Comment thread cmd/entire/cli/login.go
}

fmt.Fprintln(outW, "Waiting for approval...")
fmt.Fprintln(outW, "Waiting for approval... ")
Comment thread cmd/entire/cli/login.go
}

fmt.Fprintln(outW, "Login complete.")
fmt.Fprint(outW, " ✅ login complete.")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants