Skip to content

Slight cosmetic tweaks to output - #1343

Merged
Soph merged 5 commits into
mainfrom
20260603-adjust-login-prompt
Jun 4, 2026
Merged

Slight cosmetic tweaks to output#1343
Soph merged 5 commits into
mainfrom
20260603-adjust-login-prompt

Conversation

@toothbrush

@toothbrush toothbrush commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

https://entire.io/gh/entireio/cli/trails/496

Description

Very small prettification of things that were bothering me:

  • mise run dev:publish - i use it all the time and i like it when it tells me what it's installed
  • The login flow - i found i always had to read twice, because the URL and the "press Enter" prompt blurred together a bit. Now i think it's very readable:
$ entire login
Device code: 5XXS-2XXB
Login URL:   https://us.auth.entire.io/cli/auth?user_code=5XXS-2XXB

Press Enter to open in browser...

Waiting for approval... ✓ Login complete.

Note

Low Risk
User-facing copy and test assertions only; no auth, token, or polling logic changes.

Overview
Polishes entire login CLI output so the device code, login URL, and Enter prompt are easier to scan: renames Approval URL to a labeled Login URL: line (with spacing), shortens the interactive Press Enter text, prints Waiting for approval... on the same line as the success marker, and ends with ✅ login complete. (lowercase). Integration tests now assert the new strings and parse Login URL: instead of Approval URL:.

mise run dev:publish installs entire and git-remote-entire in a loop and prints an Installed: line per binary to stderr.

Reviewed by Cursor Bugbot for commit 7fdfa6b. Configure here.

I found the "Press Enter to..." prompt got a bit lost and i always had
to double-take.  Tried to neaten it a tiny bit.
I like seeing what has been installed.  Makes me less nervous.
@toothbrush
toothbrush requested a review from a team as a code owner June 3, 2026 08:54
Copilot AI review requested due to automatic review settings June 3, 2026 08:54
Comment thread cmd/entire/cli/login.go Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request makes small, user-facing output tweaks in the CLI to improve readability during the login device-flow, and adjusts a local dev publish task to print what it installed.

Changes:

  • Update mise run dev:publish to install entire and git-remote-entire in a loop and emit an “Installed:” line.
  • Refine entire login output formatting (URL labeling/spacing, single-line “waiting → success” flow).
  • Adjust success/waiting strings in the login flow output.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
mise-tasks/dev/publish Installs binaries one-by-one and prints an install confirmation per command.
cmd/entire/cli/login.go Tweaks device-login UX output (URL labeling, prompt formatting, waiting/success line behavior).
Comments suppressed due to low confidence (1)

cmd/entire/cli/login.go:103

  • Because "Waiting for approval..." is now written without a newline, any later error printed by main.go (to stderr) can end up on the same terminal line as the waiting message, making failure output hard to read. Adding a newline before returning the error keeps the single-line success output while preserving readable failures.
	if err != nil {
		return fmt.Errorf("complete login: %w", err)
	}

Comment thread cmd/entire/cli/login.go
Comment thread cmd/entire/cli/login.go Outdated
Match the renamed "Login URL:" prefix and lowercase "login complete."
strings from the cosmetic login output tweak.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Entire-Checkpoint: bb20852cb016
@toothbrush

Copy link
Copy Markdown
Contributor Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 7fdfa6b. Configure here.

toothbrush and others added 2 commits June 3, 2026 21:45
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Entire-Checkpoint: f8442932682e
@Soph
Soph merged commit dc9a2c7 into main Jun 4, 2026
9 checks passed
@Soph
Soph deleted the 20260603-adjust-login-prompt branch June 4, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants