Skip to content

ci: run Windows unit tests on every PR - #1878

Merged
gtrrz-victor merged 6 commits into
mainfrom
windows
Jul 31, 2026
Merged

ci: run Windows unit tests on every PR#1878
gtrrz-victor merged 6 commits into
mainfrom
windows

Conversation

@peyton-alt

@peyton-alt peyton-alt commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

https://entire.io/gh/entireio/cli/trails/956

Summary

  • add a windows-latest unit-test job to the existing pull-request CI workflow
  • run Windows/MSYS-named CLI tests with the Go version from go.mod
  • wire the Windows job into the required aggregate test check

Why

Windows-only unit tests currently skip in every per-PR job because all required CI jobs run on Ubuntu. Go reports those skips as successful, so regressions in cmd.exe wrappers, PATHEXT discovery, plugin paths, and MSYS path handling are invisible until someone runs them manually on Windows.

This keeps the initial scope targeted: it reuses the existing Windows-focused tests without attempting to make every POSIX-oriented test harness Windows-compatible.

Closes #1843.

Validation

  • mise run check
  • mise run lint
  • go test ./cmd/entire/cli/... -run (Windows|MSYS) -count=1 -v
  • YAML parse validation and git diff --check

The real Windows-only test bodies will execute in the new windows-latest CI job.


Note

Low Risk
CI workflow changes only; no runtime product or security-sensitive code paths are modified.

Overview
Adds a test-windows job on windows-latest that runs go test ./cmd/entire/cli/... with -run '(Windows|MSYS)', so Windows/MSYS-focused CLI tests actually execute on PRs instead of being skipped on Ubuntu.

The aggregate test job now depends on test-windows and fails the required check if that job does not succeed.

Reviewed by Cursor Bugbot for commit a1bfe9a. Configure here.

Entire-Checkpoint: 01KYT2ERNWE2M35RVW7TNYD1QS
Copilot AI review requested due to automatic review settings July 30, 2026 17:53
@peyton-alt
peyton-alt marked this pull request as ready for review July 30, 2026 17:54
@peyton-alt
peyton-alt requested a review from a team as a code owner July 30, 2026 17:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Windows coverage to the existing PR CI workflow by introducing a dedicated windows-latest unit-test job and gating the required aggregate test check on its success. This ensures Windows/MSYS-specific tests no longer silently skip on PRs.

Changes:

  • Added a test-windows job on windows-latest that runs go test ./cmd/entire/cli/... -run '(Windows|MSYS)'.
  • Wired the new Windows job into the required aggregate test job via needs and dependency assertions.

Comment thread .github/workflows/ci.yml
Entire-Checkpoint: 01KYT38WQJ2E5TET6V0M9YQETV
Entire-Checkpoint: 01KYT6043WEEAEXWYQ47ABE3B5
Entire-Checkpoint: 01KYT70G5B3S7CVH8AWE4WKXMT
Entire-Checkpoint: 01KYT9Q8M0PSEMNWTVW5VPRRB1
Entire-Checkpoint: 01KYTJ517H6V7YC6VM9BCR4H03
@gtrrz-victor
gtrrz-victor merged commit 942a7fe into main Jul 31, 2026
20 of 22 checks passed
@gtrrz-victor
gtrrz-victor deleted the windows branch July 31, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Windows-only unit tests silently skip in per-PR CI — add a Windows test job

3 participants