ci: run Windows unit tests on every PR - #1878
Merged
Merged
Conversation
Entire-Checkpoint: 01KYT2ERNWE2M35RVW7TNYD1QS
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Windows coverage to the existing PR CI workflow by introducing a dedicated windows-latest unit-test job and gating the required aggregate test check on its success. This ensures Windows/MSYS-specific tests no longer silently skip on PRs.
Changes:
- Added a
test-windowsjob onwindows-latestthat runsgo test ./cmd/entire/cli/... -run '(Windows|MSYS)'. - Wired the new Windows job into the required aggregate
testjob vianeedsand dependency assertions.
Entire-Checkpoint: 01KYT38WQJ2E5TET6V0M9YQETV
Entire-Checkpoint: 01KYT6043WEEAEXWYQ47ABE3B5
Entire-Checkpoint: 01KYT70G5B3S7CVH8AWE4WKXMT
Entire-Checkpoint: 01KYT9Q8M0PSEMNWTVW5VPRRB1
Entire-Checkpoint: 01KYTJ517H6V7YC6VM9BCR4H03
gtrrz-victor
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/entireio/cli/trails/956
Summary
windows-latestunit-test job to the existing pull-request CI workflowgo.modtestcheckWhy
Windows-only unit tests currently skip in every per-PR job because all required CI jobs run on Ubuntu. Go reports those skips as successful, so regressions in
cmd.exewrappers,PATHEXTdiscovery, plugin paths, and MSYS path handling are invisible until someone runs them manually on Windows.This keeps the initial scope targeted: it reuses the existing Windows-focused tests without attempting to make every POSIX-oriented test harness Windows-compatible.
Closes #1843.
Validation
mise run checkmise run lintgo test ./cmd/entire/cli/... -run (Windows|MSYS) -count=1 -vgit diff --checkThe real Windows-only test bodies will execute in the new
windows-latestCI job.Note
Low Risk
CI workflow changes only; no runtime product or security-sensitive code paths are modified.
Overview
Adds a
test-windowsjob onwindows-latestthat runsgo test ./cmd/entire/cli/...with-run '(Windows|MSYS)', so Windows/MSYS-focused CLI tests actually execute on PRs instead of being skipped on Ubuntu.The aggregate
testjob now depends ontest-windowsand fails the required check if that job does not succeed.Reviewed by Cursor Bugbot for commit a1bfe9a. Configure here.