fix: exclude self-filed-and-self-solved issues from mirror valid-solved gate#835
Open
polyjeff529 wants to merge 1 commit intoentrius:testfrom
Open
Conversation
polyjeff529
commented
Apr 28, 2026
…ed gate The mirror issue-discovery path increments `valid_solved_count` before the same-account (self-issue) check. A miner with six legitimate cross-account discoveries plus one self-filed-and-self-solved issue would clear the `MIN_VALID_SOLVED_ISSUES = 7` gate on padding rather than work — the seventh "solve" proves no cross-account discovery activity. The discovery-score path already excludes self-solves at the same site (gives credibility only); the valid-solved gate must do the same so it cannot be cleared via self-padding. Compute `is_self_solved` once, gate `valid_solved_count++` on it, and reuse the same flag for the existing same-account credibility-only branch. Tightens the existing self-issue test to also assert `total_valid_solved_issues == 0`, and adds a regression covering the 6-cross + 1-self mix that the gate must reject. `total_solved_issues` (credibility input) and the discovery-score path are unchanged — self-issues still feed credibility, and same-account solves still produce no discovery_earned_score.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.