fix(cli): validate --id range on gitt i list to match sibling commands

[plind-junior]

Summary

gitt i list --id <N> accepted 0, negative numbers, and out-of-u32-range values and passed them straight through to on-chain lookup, returning a misleading "Issue N not found on-chain" message. Every sibling command using the same issue_id semantics (i submissions, vote solution, vote cancel) already rejects these inputs via validate_issue_id and emits a structured bad_parameter error. view.py:issues_list was the only outlier.

Closes the gap left by #210 / PR #211, which prescribed this validation across the CLI but listed only mutations.py / vote.py / admin.py — view.py was outside that scope.

Type of Change

• Bug fix
• New feature
• Refactor
• Documentation
• Other

Reproduction (before this PR)

$ gitt i submissions --id 0
✗ id must be between 1 and 999999 (got 0)              # ✅ rejected at input

$ gitt vote solution 0 5Hxxx... 5Hyyy... 1
✗ id must be between 1 and 999999 (got 0)              # ✅ rejected at input

$ gitt i list --id 0
Network: finney • Contract: ...
✗ Issue 0 not found on-chain.                          # ❌ silently did an on-chain query

$ gitt i list --id -1
✗ Issue -1 not found on-chain.                         # ❌ negative passed through

$ gitt i list --id 99999999999999
✗ Issue 99999999999999 not found on-chain.             # ❌ way out of u32 range, also passed through

Verified on upstream/test HEAD d8ba803.

After

$ gitt i list --id 0
✗ id must be between 1 and 999999 (got 0)              # ✅ matches submissions / vote

$ gitt i list --id 0 --json
{"success": false, "error": {"type": "bad_parameter", "message": "id must be between 1 and 999999 (got 0)"}}

$ gitt i list --id 1                                   # valid IDs unaffected
Network: finney • Contract: ...
✗ Issue 1 not found on-chain.                          # PR #335's structured not-found path preserved

$ gitt i list                                          # no --id, list-all path unchanged

Why this isn't a duplicate

• gitt cli improvements #210 (CLOSED COMPLETED) prescribed the rule: "1 <= value < 1_000_000 on all commands that accept an issue ID or number." The issue's file list named only mutations.py, vote.py, admin.py, so PR feat(cli): harden and polish issue commands #211 honored that scope and didn't touch view.py. This PR closes the leftover gap.
• PR fix: issues list --json --id returns null instead of structured error for missing issues #335 (MERGED) previously tuned this exact code path — it changed the not-found JSON output from bare null to a structured {success: false, error: {...}} payload. This PR does not regress that contract: validation rejects at parse time via click.BadParameter before any contract read; the structured not-found behavior remains for valid IDs that don't exist on-chain (regression-tested below).
• PR Extract require_valid_issue_id and require_valid_ss58 helpers to deduplicate CLI validation #497 (MERGED) factored out require_valid_issue_id / validate_issue_id helpers — already imported and used elsewhere, just not wired into issues_list.

Implementation

gittensor/cli/issue_commands/view.py:issues_list:

from .helpers import (
    ...
    validate_issue_id,
    ...
)

def issues_list(issue_id: int, ...):
    if issue_id is not None:
        try:
            validate_issue_id(issue_id, 'id')
        except click.BadParameter as e:
            handle_exception(as_json, str(e), 'bad_parameter')
    contract_addr, ws_endpoint, network_name = _resolve_contract_and_network(...)
    ...

Mirrors the existing pattern at submissions.py:57-60. Single gate at function entry; no new helpers, no new constants.

Testing

tests/cli/test_issues_list_json.py — 7 new parametric cases plus the 2 existing PR #335 regression tests:

Case	Mode	Asserts
--id 0, -1, 1000000, 99999999999999	human	exit non-zero, "between 1 and 999999" in stderr, no contract read (mock not called)
--id 0, -1, 1000000	--json	exit non-zero, structured {success: false, error: {type: bad_parameter, ...}}, no contract read
--id 999 (valid, missing)	both	PR #335's structured not_found path still fires (regression-locked)

$ pytest tests/cli/test_issues_list_json.py -v
9 passed in 0.08s

$ pytest tests/ -q --ignore=tests/test_synapses.py
659 passed, 2 warnings in 2.98s

Ruff lint + format clean on view.py and the test file.

Scope

• 2 files changed, +34/-0 lines.
• No API changes, no new dependencies, no behavior change for valid IDs or for the list-all path.
• Aligns i list --id with i submissions --id, vote solution, vote cancel, and i register --id.

Related

• Closes the view.py gap from gitt cli improvements #210 / PR feat(cli): harden and polish issue commands #211.
• PR fix: issues list --json --id returns null instead of structured error for missing issues #335 — not regressed; explicitly covered by an existing test that this PR keeps passing.
• PR Extract require_valid_issue_id and require_valid_ss58 helpers to deduplicate CLI validation #497 — uses the helpers it landed.

Fixes #854

Labels

bug