fix: close all sessions in session_scope even when one close() raises (follow-up of #687)#859
Open
wdeveloper16 wants to merge 1 commit intoentrius:testfrom
Open
fix: close all sessions in session_scope even when one close() raises (follow-up of #687)#859wdeveloper16 wants to merge 1 commit intoentrius:testfrom
wdeveloper16 wants to merge 1 commit intoentrius:testfrom
Conversation
7caeea8 to
e7391a8
Compare
e7391a8 to
7c1f352
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #687. Closes #858.
Problem
In
session_scope()'sfinallyblock, if the firstsession.close()raises, the loop aborts and every remaining session in the cache is leaked:Fix
Wrap each
close()individually so all sessions are always attempted. The first exception, if any, is re-raised after the full iteration:Test
Adds
test_all_sessions_closed_even_when_first_close_raisestoTestSessionScope: two sessions are created, the firstclose()is made to raise, and the test asserts both sessions hadclose()called and_session_cacheisNone.