Turns a shared_ptr argument whose lifetime is not in doubt into a reference#44659
Open
birenroy wants to merge 2 commits intoenvoyproxy:mainfrom
Open
Turns a shared_ptr argument whose lifetime is not in doubt into a reference#44659birenroy wants to merge 2 commits intoenvoyproxy:mainfrom
birenroy wants to merge 2 commits intoenvoyproxy:mainfrom
Conversation
…erence. Signed-off-by: Biren Roy <birenroy@google.com>
birenroy
requested review from
mattklein123,
tyxia and
yanavlasov
as code owners
Contributor
Author
|
/assign @RyanTheOptimist |
Signed-off-by: Biren Roy <birenroy@google.com>
Contributor
Author
|
/assign @adisuissa |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minimal updating was required for the upstream case, where no filter chain map exists.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]