otel: add option to disable telemetry SDK resource attributes#44689
Open
fcfort wants to merge 3 commits intoenvoyproxy:mainfrom
Open
otel: add option to disable telemetry SDK resource attributes#44689fcfort wants to merge 3 commits intoenvoyproxy:mainfrom
fcfort wants to merge 3 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Frank Fort <ffort@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Frank Fort <ffort@google.com>
Signed-off-by: Frank Fort <ffort@google.com>
Contributor
Author
|
/retest due to errors downloading packages in CI |
adisuissa
reviewed
Apr 28, 2026
Contributor
adisuissa
left a comment
There was a problem hiding this comment.
/lgtm api
Assigning @yanavlasov as codeowner
/assign @yanavlasov
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: otel: add option to disable telemetry SDK resource attributes
Additional Description:
Currently, the OpenTelemetry tracer always populates telemetry SDK attributes (
telemetry.sdk.language,telemetry.sdk.name,telemetry.sdk.version).We have a customer-facing user interface for viewing traces and we don't want to leak internal Envoy details of our product.
This PR introduces a new configuration option
set_telemetry_sdk_resource_attributes(default true) inOpenTelemetryConfigto allow opting-out of populating these attributes. When set to false, the attributes listed above will be omitted from the resource spans.The new behavior (omitting attributes) is default off to preserve backward compatibility.
Risk Level: Low
Testing:
Docs Changes: None.
Release Notes: Added a configuration option to disable populating telemetry SDK attributes in the OpenTelemetry tracer.
Platform Specific Features: None.
Runtime guard: None.
[Disclosed usage of generative AI: Yes, used to assist in code modifications.]