Make character tables more readable#44691
Draft
ravenblackx wants to merge 2 commits intoenvoyproxy:mainfrom
Draft
Make character tables more readable#44691ravenblackx wants to merge 2 commits intoenvoyproxy:mainfrom
ravenblackx wants to merge 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Make character tables more readable
Additional Description: Character tables have been created as an array of binary values with comments. This PR uses modern constexpr to generate them with code, so they're still constexpr and performance should be identical, but the code is more readable, no need to manually read every bit to see what's happening.
Risk Level: Should be no change, but there is some risk that I missed or added one bit. The existing test coverage is fairly aggressive with checking every character, so I think the risk of that is low.
Testing: Added some tests that the constexpr generators are generating the expected outcomes.
Docs Changes: n/a
Release Notes: n/a