Skip to content

Make character tables more readable#44691

Draft
ravenblackx wants to merge 2 commits intoenvoyproxy:mainfrom
ravenblackx:char_tables
Draft

Make character tables more readable#44691
ravenblackx wants to merge 2 commits intoenvoyproxy:mainfrom
ravenblackx:char_tables

Conversation

@ravenblackx
Copy link
Copy Markdown
Contributor

Commit Message: Make character tables more readable
Additional Description: Character tables have been created as an array of binary values with comments. This PR uses modern constexpr to generate them with code, so they're still constexpr and performance should be identical, but the code is more readable, no need to manually read every bit to see what's happening.
Risk Level: Should be no change, but there is some risk that I missed or added one bit. The existing test coverage is fairly aggressive with checking every character, so I think the risk of that is low.
Testing: Added some tests that the constexpr generators are generating the expected outcomes.
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Raven Black <ravenblack@dropbox.com>
@repokitteh-read-only
Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #44691 was opened by ravenblackx.

see: more, trace.

Signed-off-by: Raven Black <ravenblack@dropbox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant