Null check filterManagerConnection to prevent segfaults#46018
Open
michalkielan wants to merge 1 commit into
Open
Null check filterManagerConnection to prevent segfaults#46018michalkielan wants to merge 1 commit into
michalkielan wants to merge 1 commit into
Conversation
Signed-off-by: Michal Kielan <michalkielan@protonmail.com>
michalkielan
force-pushed
the
fix-quic-null-crash
branch
from
a49fb1c to
2576079
Compare
danzh2010
reviewed
Jul 9, 2026
| stats_.tx_reset_.inc(); | ||
| filterManagerConnection()->incrementSentQuicResetStreamErrorStats(error, /*from_self*/ true, | ||
| /*is_upstream*/ true); | ||
| if (filterManagerConnection() != nullptr) { |
Contributor
There was a problem hiding this comment.
This can't be null. Which test are you seeing the flakiness?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Null check filterManagerConnection to prevent segfaults
Additional Description: Test cleanup could cause filterManagerConnection() to return nullptr leads to a segmentation fault.
Risk Level: none
Testing: quic_protocol_integration_test
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a