stats: enable tag-extraction check for metrics_service integration test#46062
Open
davidvo-lyft wants to merge 1 commit into
Open
stats: enable tag-extraction check for metrics_service integration test#46062davidvo-lyft wants to merge 1 commit into
davidvo-lyft wants to merge 1 commit into
Conversation
The metrics_service stats-sink integration test skipped the missing-tag-extraction-rule check with a stale TODO. The cited stat (grpc.metrics_service.streams_closed_*) is now covered by the grpc.$.** rule added in envoyproxy#36673, so enable the check and add direct unit coverage for the google_grpc client prefix. Partially addresses envoyproxy#21595. Signed-off-by: David Vo <davidvo@lyft.com>
davidvo-lyft
requested a deployment
to
external-contributors
GitHub Actions
Waiting
|
Hi @davidvo-lyft, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The metrics_service stats-sink integration test skipped the missing-tag-extraction-rule check with a stale TODO. That stat (
grpc.metrics_service.streams_closed_*) is now covered by thegrpc.$.**rule from #36673, so this enables the check and adds direct unit coverage for the google_grpc client prefix.Risk Level: Low (test only)
Testing:
tag_extractor_impl_testand the metrics_service integration test pass with the check enabled.Docs Changes: n/a
Release Notes: n/a
Partially addresses #21595.