stats: enable tag-extraction check for ratelimit, scoped_rds, open_telemetry tests#46064
Open
davidvo-lyft wants to merge 1 commit into
Open
stats: enable tag-extraction check for ratelimit, scoped_rds, open_telemetry tests#46064davidvo-lyft wants to merge 1 commit into
davidvo-lyft wants to merge 1 commit into
Conversation
…lemetry tests These integration tests skipped the missing-tag-extraction-rule check with 2022-era TODOs citing stats that lacked rules at the time. Those rules now exist (e.g. grpc.$.** from envoyproxy#36673 covers the open_telemetry gRPC-client stats; the scoped_rds gRPC-client stats are extracted by the SCOPED_RDS_CONFIG rule). Enable the check in ratelimit, scoped_rds (and the shared InlineScopedRoutes fixture), and the open_telemetry stats sink. Because scoped_rds.h is shared, the on_demand and odcds tests are also covered. All five affected targets pass with the check enabled. Partially addresses envoyproxy#21595. Signed-off-by: David Vo <davidvo@lyft.com>
davidvo-lyft
requested a deployment
to
external-contributors
GitHub Actions
Waiting
|
Hi @davidvo-lyft, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These integration tests skipped the missing-tag-extraction-rule check with 2022-era TODOs citing stats that lacked rules at the time. Those rules now exist (e.g.
grpc.$.**from #36673 covers the open_telemetry gRPC-client stats; scoped_rds gRPC-client stats are extracted bySCOPED_RDS_CONFIG). This enables the check in ratelimit, scoped_rds (and the sharedInlineScopedRoutesfixture), and the open_telemetry stats sink. Sincescoped_rds.his shared, the on_demand and odcds tests are covered too.Risk Level: Low (test only)
Testing: all five affected targets (ratelimit, scoped_rds, open_telemetry, on_demand, odcds) pass with the check enabled.
Docs Changes: n/a
Release Notes: n/a
Partially addresses #21595.