Skip to content

feat: add internal condition bypass to ListSourceAccounts and ListRestoreAccounts#65

Closed
SivanAfek wants to merge 1 commit intomainfrom
devin/1772014724-list-accounts-condition
Closed

feat: add internal condition bypass to ListSourceAccounts and ListRestoreAccounts#65
SivanAfek wants to merge 1 commit intomainfrom
devin/1772014724-list-accounts-condition

Conversation

@SivanAfek
Copy link
Copy Markdown
Collaborator

Summary

Adds an optional *Condition parameter to ListSourceAccounts and ListRestoreAccounts in the Eon client. When a condition is provided, the client bypasses the SDK and sends a raw HTTP POST request with the condition directly in the request body. This supports an internal bypass mechanism where condition-based queries skip the normal filter pipeline on the server side.

All existing callers are updated to pass nil, preserving current behavior.

Companion server-side PR: https://github.com/eon-io/eon-service/pull/23515

Review & Testing Checklist for Human

  • Auth in custom HTTP path: The listSourceAccountsWithCondition / listRestoreAccountsWithCondition methods copy headers from DefaultHeader but bypass the SDK's request pipeline. Verify this is sufficient for authentication (same pattern as StartBigQueryDatasetRestore). If the SDK injects auth tokens outside of DefaultHeader, the condition path will fail silently with 401s.
  • No pagination in condition path: The raw HTTP requests don't pass pageToken/pageSize. Confirm this is acceptable, or whether large result sets could be silently truncated.
  • Deployment order: This PR depends on the server-side condition support (eon-service#23515) being deployed first. Sending a condition to an older server that doesn't recognize the field should be harmless (server ignores unknown JSON fields), but verify this assumption.

Notes

@devin-ai-integration
Copy link
Copy Markdown

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@SivanAfek SivanAfek closed this Feb 26, 2026
@devin-ai-integration
Copy link
Copy Markdown

Closing this PR - internal fields are not exposed in the SDK and should not be accessed via terraform. The condition bypass is only needed on the server side (eon-service).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant