feat: add internal condition bypass to ListSourceAccounts and ListRestoreAccounts#65
Closed
feat: add internal condition bypass to ListSourceAccounts and ListRestoreAccounts#65
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Closing this PR - internal fields are not exposed in the SDK and should not be accessed via terraform. The condition bypass is only needed on the server side (eon-service). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
*Conditionparameter toListSourceAccountsandListRestoreAccountsin the Eon client. When a condition is provided, the client bypasses the SDK and sends a raw HTTP POST request with the condition directly in the request body. This supports an internal bypass mechanism where condition-based queries skip the normal filter pipeline on the server side.All existing callers are updated to pass
nil, preserving current behavior.Companion server-side PR: https://github.com/eon-io/eon-service/pull/23515
Review & Testing Checklist for Human
listSourceAccountsWithCondition/listRestoreAccountsWithConditionmethods copy headers fromDefaultHeaderbut bypass the SDK's request pipeline. Verify this is sufficient for authentication (same pattern asStartBigQueryDatasetRestore). If the SDK injects auth tokens outside ofDefaultHeader, the condition path will fail silently with 401s.pageToken/pageSize. Confirm this is acceptable, or whether large result sets could be silently truncated.Notes