(EON-8377) fix: read role from API response in restore account create#68
Merged
assafr-eon merged 1 commit intomainfrom Mar 31, 2026
Merged
Conversation
The create path was copying `role` from plan data, which can be "unknown" when role_arn depends on a resource replaced in the same apply. Read from the API response instead, matching how Read and ImportState already work. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dor-eon
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Createfunction foreon_restore_accountwas copyingrolefrom plan data (data.Aws.RoleArn), which can be "unknown" whenrole_arndepends on a resource replaced in the same apply (e.g.replace_triggered_by)Provider returned invalid result object after applybecause unknown values are not allowed after createrolefrom the API response, matching howReadandImportStatealready workTest plan
terraform applywithreplace_triggered_by = [aws_iam_role.eon_restore_account_role]no longer failsrolefield still populated correctly after create🤖 Generated with Claude Code