feat(chat): Added deleting of attachment from device after its unselection (Issue #7128)#7131
Merged
Merged
Conversation
Kuznietsov
requested review from
Alexander-Kezik,
Derikyan,
Gimir,
PolinaGurinovich97 and
denys-kolomiitsev
as code owners
Kuznietsov
changed the title
Contributor
|
/deploy-review
|
Kuznietsov
changed the title
denys-kolomiitsev
changed the title
Contributor
|
/deploy-review
|
denys-kolomiitsev
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #7128
Description of changes
When a file was attached in Chat via drag-and-drop (or other quick upload paths), it was added to state.files.files and selected for the message. Removing the attachment chip only cleared it from selectedFilesIds, so the file remained in state.files.files. In-flight uploads were cancelled but not removed from state; completed uploads were not cleaned up at all.
Unselecting a quick-uploaded attachment before sending should fully remove it from the files store (and from storage when already uploaded). Files picked from the file manager should only be deselected and remain available in storage. Quick uploads are now marked with isQuickAttachment and deleted on unselect via the existing deleteFile flow.
UI changes
Screen.Recording.2026-06-10.at.07.57.28.mov
Checklist
(Issue #<ISSUE_ID>)(comma-separated list of issues)