Draft
Reject case class fields that reference mutable object-level vals#1738
Conversation
|
|
Copilot
AI
changed the title
[WIP] Fix unsound field encoding in case classes with mutation
Reject case class fields that reference mutable object-level vals
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Case class
valfields whose bodies reference mutable object-level vals (globals in Scalaobjects) were silently accepted as pure, producing unsound verification results. The root cause:val c = Counter(0)in anobjectis extracted asdef c(): Counter = Counter(0)— a zero-argument pure function — soeffects(fd.fullBody)forval y = c.next()returns empty, bypassing the existing purity check.Changes
ast/Definitions.scala— NewIsModuleValflag ("moduleVal") to mark object-level val definitions, plus itsextractFlagentry.ast/Deconstructors.scala— Deconstruct/reconstruct case forIsModuleValso the flag survives all pipeline transformations.CodeExtraction.scala(extractStatic) — AppendsIsModuleValto the flags of bothExNonCtorFieldDefandExLazyFieldDefextracted from objects.EffectsChecker.scala(checkMutableField) — Added apreTraversalpass over the field body: anyFunctionInvocationto a function carryingIsModuleValwhose return type is mutable now throwsImperativeEliminationException, rejecting the program with a clear error message.frontends/benchmarks/extraction/invalid/MutableModuleValField.{scala,check}— Negative test reproducing the issue.