Skip to content

Support for 1D and 2D systems with kcp.x - #213

Draft
elinscott wants to merge 4 commits into
masterfrom
supporting_1d_and_2d
Draft

Support for 1D and 2D systems with kcp.x#213
elinscott wants to merge 4 commits into
masterfrom
supporting_1d_and_2d

Conversation

@elinscott

Copy link
Copy Markdown
Collaborator

No description provided.

@pep8speaks

pep8speaks commented Nov 6, 2023

Copy link
Copy Markdown

Hello @elinscott! Thanks for updating this PR.

Line 409:121: E501 line too long (179 > 120 characters)

Comment last updated at 2023-11-30 12:30:31 UTC

@elinscott

Copy link
Copy Markdown
Collaborator Author

Note to self: line ~120 of _unfold_and_interp.py references undefined energies (rename missed one line) — every spin-polarized U&I run crashes. Also the calculate_alpha guard got commented out, so the image-correction block runs unconditionally on DFT-only workflows. Fix both if this is ever revived.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants