Enable pool and pencil decomposition for kcw.x - #253
Merged
Conversation
nscolonna
changed the title
kcw.xpool and pencil depdomposition for kcw.x
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #253 +/- ##
==========================================
+ Coverage 80.67% 81.25% +0.58%
==========================================
Files 97 97
Lines 8191 8116 -75
==========================================
- Hits 6608 6595 -13
+ Misses 1583 1521 -62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nscolonna
changed the title
pool and pencil depdomposition for kcw.xpool and pencil decomposition for kcw.x
elinscott
requested changes
Sep 29, 2025
| pd: bool = Field(False, description="Use pencil decomposition.") | ||
| ase_env_var: ClassVar[str] = "ASE_PROJWFC_COMMAND" | ||
|
|
||
| @property |
Collaborator
There was a problem hiding this comment.
Please add missing options_str implementation
elinscott
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR reintroduce
npooland addpdas possible parallelization options forkcw.x. At the moment there is no way to instructkoopmansto runkcw.xwith k-point and/or pencil decomposition (This went probably lost with MR #245).