Draft
Conversation
mdavidsaver
reviewed
Apr 16, 2026
Comment on lines
+114
to
+116
| ifeq ($(USE_BUNDLE),YES) | ||
| BIN_INSTALLS_WIN32 += $(wildcard $(LIBEVENT_PREFIX)/lib/*.dll) | ||
| endif |
Member
There was a problem hiding this comment.
While I understand the motivation of avoiding %PATH% manipulation, I don't like mixing together libevent and PVXS binaries.
Member
|
Taking a step back, how is |
Author
|
this is done by usual EPICS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
BUNDLE_BUILDis set toYESvia e.g.CONFIG_SITE.localthen amakeat top level will buildlibeventfrombundledirectory without it needing to be built separately first;bundleis also added to the clean target and DLLs are installed to pvxs bin directory so the libevent bin area does not need to be separately added to windowsPATH